Fix : GemVersion TypeError unhashable type: 'list' - #98
Merged
Conversation
Contributor
|
@ziadhany please update your branch with latest main |
fix test_canonical_segments test Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Contributor
|
@ziadhany please add a test to verify your changes |
pombredanne
approved these changes
Feb 10, 2023
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM! we still would want to have a hash() test to validate we can hash a GemVersion... this is good to go otherwise.
Member
|
@TG1999 if you want to add the test and merge, you can then cut a release IMHO :) |
Reference: aboutcode-org/vulnerablecode#926 Reference: aboutcode-org/vulnerablecode#608 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
I committed the new test! |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ziadhany ziadhany2016@gmail.com